Makefile: simplify document generation targets #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryzj
changed the title
Collaborator
|
I prefer keep the git operations, that's useful when commit those auto generated stuffs, otherwise other two patches are LGTM |
jerryzj
force-pushed
the
dev/jerryzj/simplify-makefile
branch
from
669e83d to
1dd309a
Compare
Collaborator
Author
|
@kito-cheng ok, git operations are kept and replaced by parametrized targets. |
jerryzj
force-pushed
the
dev/jerryzj/simplify-makefile
branch
from
1dd309a to
84fbf9a
Compare
jerryzj
force-pushed
the
dev/jerryzj/simplify-makefile
branch
from
84fbf9a to
8ae5801
Compare
Collaborator
|
Could you rebase to main branch since post-1.0 branch is merged back |
Signed-off-by: Jerry Zhang Jian <[email protected]>
Signed-off-by: Jerry Zhang Jian <[email protected]>
jerryzj
force-pushed
the
dev/jerryzj/simplify-makefile
branch
from
8ae5801 to
37efdd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes
Signed-off-by: Jerry Zhang Jian [email protected]